[GitHub] solomax commented on issue #3: [DIRAPI-324] commons-lang and commons-collections are updated

[GitBox]

solomax commented on issue #3: [DIRAPI-324] commons-lang and commons-collections are updated
URL: https://github.com/apache/directory-ldap-api/pull/3#issuecomment-439266031


great news :)
BTW are you planing to move to JUnit5?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
***@infra.apache.org


With regards,
Apache Git Services

[GitBox]

solomax commented on issue #3: [DIRAPI-324] commons-lang and commons-collections are updated
URL: https://github.com/apache/directory-ldap-api/pull/3#issuecomment-439342058


All asserts will need to be rewritten :(
```
JUnit4: assert*(string?, expected, actual)
JUnit5: assert*(string?, actual, expected)
```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
***@infra.apache.org


With regards,
Apache Git Services

[GitBox]

solomax commented on issue #3: [DIRAPI-324] commons-lang and commons-collections are updated
URL: https://github.com/apache/directory-ldap-api/pull/3#issuecomment-439423779


Already did it like this on huge project ~200 submosules
Move to junit5 (make the build green)
Will do assertion migration baby-steps :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
***@infra.apache.org


With regards,
Apache Git Services