[GitHub] elecharny commented on issue #3: [DIRAPI-324] commons-lang and commons-collections are updated

[GitBox]

elecharny commented on issue #3: [DIRAPI-324] commons-lang and commons-collections are updated
URL: https://github.com/apache/directory-ldap-api/pull/3#issuecomment-439099383


PR applied.

Many thanks !

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
***@infra.apache.org


With regards,
Apache Git Services

[GitBox]

elecharny commented on issue #3: [DIRAPI-324] commons-lang and commons-collections are updated
URL: https://github.com/apache/directory-ldap-api/pull/3#issuecomment-439341084


Not scheduled yet... Considering the 5000+ tests we have, it's a move that is a bit scarying, TBH...

Also I have no ida what that would imply in term of refactoring, it may be quite simple, or require a hal of rewrite...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
***@infra.apache.org


With regards,
Apache Git Services

[GitBox]

elecharny commented on issue #3: [DIRAPI-324] commons-lang and commons-collections are updated
URL: https://github.com/apache/directory-ldap-api/pull/3#issuecomment-439346741


OMFG ;-)

Well, we can live with the 'expected' and 'actual' being inverted for a while ;-) That does not change the result !

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
***@infra.apache.org


With regards,
Apache Git Services

[GitBox]

elecharny commented on issue #3: [DIRAPI-324] commons-lang and commons-collections are updated
URL: https://github.com/apache/directory-ldap-api/pull/3#issuecomment-439401403


We can change them little by little. Typically the kind of stupid task you do when you're almost brain dead but still want to do something useful :-) The key is to track down the progress.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
***@infra.apache.org


With regards,
Apache Git Services

[GitBox]

elecharny commented on issue #3: [DIRAPI-324] commons-lang and commons-collections are updated
URL: https://github.com/apache/directory-ldap-api/pull/3#issuecomment-439623826


I think I fixed it late yesturday. I’ll double check.

Not sure what happened when this was merged, but 1378a30
<https://github.com/apache/directory-ldap-api/commit/1378a300c409f2b1295249177b0d767952de70fe>
contains also other changes that break master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/apache/directory-ldap-api/pull/3#issuecomment-439613486>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACyYFXW9aoSq1NCpppMj1bWJtuEkwuvTks5uwAKygaJpZM4Xx22B>
.

--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
***@infra.apache.org


With regards,
Apache Git Services

[Emmanuel Lecharny]

It's quite weird. Seems like my commit wasn't injected into the code base.
It builds just fine on my computer, and I have everything pushed. I had to
inject some more modification to then see the missing class in the repo.

It should come back to normal soon, when Jenkins will be done building the
project (FTR it passes the part that was failing).

Post by GitBox
elecharny commented on issue #3: [DIRAPI-324] commons-lang and
commons-collections are updated
https://github.com/apache/directory-ldap-api/pull/3#issuecomment-439623826
I think I fixed it late yesturday. I’ll double check.
a

Not sure what happened when this was merged, but 1378a30
<

https://github.com/apache/directory-ldap-api/commit/1378a300c409f2b1295249177b0d767952de70fe

contains also other changes that break master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<

https://github.com/apache/directory-ldap-api/pull/3#issuecomment-439613486

,
or mute the thread
<

https://github.com/notifications/unsubscribe-auth/ACyYFXW9aoSq1NCpppMj1bWJtuEkwuvTks5uwAKygaJpZM4Xx22B

.

--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
With regards,
Apache Git Services